consolidate routed-experts capturer onto reusable base#24403
Merged
Conversation
hnyls2002
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
iforgetmyname,
ispobock,
merrymercy,
ping1jing2 and
xiezhq-hermann
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-test test_return_routed_experts.py |
Contributor
|
✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor of the routed-experts capturer; prep for an upcoming indexer-topk capturer (stacked PR) that reuses the same base.
RoutedExpertsCapturerABC +_RoutedExpertsCapturerNoop—create()returnsOptional[RoutedExpertsCapturer], callers useis not Nonechecks.BaseTopkCapturer/BaseHostCache/BaseDeviceCache/TopkCaptureOutputtopython/sglang/srt/layers/topk_capturer_base.py.RoutedExpertsCapturernow inheritsBaseTopkCapturer; overrides only_get_local_slicefor DP-rank-aware slicing + dropping fused shared experts columns.enable_return_routed_experts=True; only allocation log strings differ (now taggedHostCache[routed_experts]/DeviceCache[routed_experts]).